Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APIC-66] ENH add job and run IDs as custom headers in API calls #437

Merged
merged 6 commits into from
Dec 1, 2021

Conversation

jacksonlee-civis
Copy link
Member

This PR adds job and run IDs as custom headers in API calls, so that jobs and runs are more easily identifiable by their IDs through Civis Platform's logging.

  • (For Civis employees only) Reference to a relevant ticket in the pull request title
  • Changelog entry added to CHANGELOG.md at the repo's root level
  • Description of change in the pull request description
  • The CircleCI builds have all passed

@jacksonlee-civis
Copy link
Member Author

@mattyb Tagging you for review for this pull request, but I'm going to move the discussion to the linked ticket, in order to avoid discussing internal Platform knowledge in a public repo here.

Copy link
Member

@mattyb mattyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacksonlee-civis jacksonlee-civis merged commit fe88156 into master Dec 1, 2021
@jacksonlee-civis jacksonlee-civis deleted the apic-66-job-run-ids-in-api-calls branch December 1, 2021 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants