[CIVP-24576] FIX relax SQL type checking in civis_file_to_table
#439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacksonlee-civis
commented
Dec 2, 2021
There was a problem hiding this comment.
@skomanduri Tagging you for review, since there's a small chance that this PR requires internal Platform knowledge that you'd know better than anyone else
skomanduri
previously approved these changes
Dec 9, 2021
skomanduri
suggested changes
Dec 10, 2021
There was a problem hiding this comment.
@jacksonlee-civis Got it. Thanks for explaining your process. I was able to do some verification myself using the same methodology and script you provided and I couldn't get this to break with the cases I tried, so I think this is good to go! I just found one small issue where the column name might not get pulled from the file but might be auto-generated instead. Feel free to code it differently if you want.
...rather than throwing an error for the first problematic file found, and thereby masking potential subsequent, similar errors and slowing down the entire work/debugging process
|
@skomanduri Thank you for catching the column name issue -- this PR is ready for another pass! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request relaxes SQL type checking in
civis.io.civis_file_to_table, by casting toVARCHARwhen type inconsistency is detected for a given column and at least one input file hasVARCHAR.CHANGELOG.mdat the repo's root level