Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIVIS-1775] FIX updated location of civis_api_spec.json in setup py #441

Merged
merged 2 commits into from
Dec 2, 2021

Conversation

jacksonlee-civis
Copy link
Member

As a follow-up of #440, this PR fixes setup.py for the new location of civis_api_spec.json. Locally, I've verified by creating and examining a source distribution tarball that this PR would correctly include the JSON file under civis/resources/.

  • (For Civis employees only) Reference to a relevant ticket in the pull request title
  • Changelog entry added to CHANGELOG.md at the repo's root level
  • Description of change in the pull request description
  • The CircleCI builds have all passed

Copy link

@madopal madopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jacksonlee-civis jacksonlee-civis merged commit 53723af into master Dec 2, 2021
@jacksonlee-civis jacksonlee-civis deleted the civis-1775-fix-setup-py branch December 2, 2021 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants