Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CIVIS-1851] DOC update info about MacOS shell config file #444

Merged
merged 3 commits into from
Dec 8, 2021
Merged

[CIVIS-1851] DOC update info about MacOS shell config file #444

merged 3 commits into from
Dec 8, 2021

Conversation

jacksonlee-civis
Copy link
Member

MacOS has switched to ZSH as the default shell, but our docs still mention .bash_profile for the API key set-up. This PR updates the docs.

  • (For Civis employees only) Reference to a relevant ticket in the pull request title
  • Changelog entry added to CHANGELOG.md at the repo's root level
  • Description of change in the pull request description
  • The CircleCI builds have all passed

@jacksonlee-civis jacksonlee-civis added this to the v1.16.0 milestone Dec 8, 2021
mattyb
mattyb approved these changes Dec 8, 2021
View reviewed changes
Copy link
Member

@mattyb mattyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacksonlee-civis jacksonlee-civis merged commit 1b6a83d into master Dec 8, 2021
@jacksonlee-civis jacksonlee-civis deleted the civis-1851-zshrc branch December 8, 2021 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattyb mattyb mattyb approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v1.16.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jacksonlee-civis @mattyb