Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: hyperband now supported with stacking #132

Merged
merged 1 commit into from
Aug 2, 2018

Conversation

patr1ckm
Copy link
Contributor

@patr1ckm patr1ckm commented Aug 2, 2018

We tried to be helpful and fail early with a helpful error message for models where hyperband isn't supported. Since hyperband is now supported for stacking estimators, we can remove the error.

Is multi-output still not supported for these?

c("sparse_linear_regressor", "sparse_ridge_regressor",
"gradient_boosting_regressor",
"sparse_logistic", "gradient_boosting_classifier")

Fixes #131

@patr1ckm patr1ckm requested review from elsander and removed request for elsander August 2, 2018 19:50
Copy link
Contributor

@elsander elsander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Yeah, multi-output is still not supported for those estimators (or the stacking estimators, or MLP regressor).

@elsander elsander assigned patr1ckm and unassigned elsander Aug 2, 2018
@patr1ckm patr1ckm merged commit 50048a3 into civisanalytics:master Aug 2, 2018
@patr1ckm patr1ckm deleted the 131-hyperband branch August 2, 2018 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants