-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate the "local" argument in CivisFuture() #247
Conversation
DESCRIPTION
Outdated
@@ -1,8 +1,9 @@ | |||
Package: civis | |||
Title: R Client for the 'Civis Platform API' | |||
Version: 3.0.0 | |||
Version: 3.0.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this change is worth a minor version bump https://semver.org/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done!
@@ -2,6 +2,9 @@ | |||
|
|||
## Unreleased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're bumping the version number in DESCRIPTION
, I think you should add a [3.1.0]
section here in the changelog also. Other than that, looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done!
This PR address issue #244:
civis
packagelifecycle
package as a dependency (to warn users of the new deprecated argument)local
argument to be deprecated (+ in documentation)local
argument is suppliedlocal
argument from future::Future()@inheritParams fetch_output_file_ids
. All arguments forfetch_output
were already present, so this was raining a warning when building the Roxygen2 documentation.x, newdata
, Because the documentation forx
was not getting properly inherited into the documentation of the CivisML functions (this was causing an R CMD CHECK warning)man
folder were generated when I re-generated the default client (userun_generate_client.R
in thetools
directory)