Fixed Deprecated Package(s) Dependencies #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… sklearn. More proper to export directly instead of relying on sklearn externals and exposed packages which have no guarantees for maintainence and accessibility.
mheilman
requested changes
Oct 27, 2020
|
Oops!!! Totally forgot about flake8, sorry about that! |
…ments for MaskedArray serializable fix, flake8 formatting
daliu
force-pushed
the
fix_deprecated_imports
branch
from
8708d2a
to
d5f1801
Compare
|
Ok, so I noticed that Travis CI is breaking down specifically on Python 2.7, 3.4, and 3.5 all of which are deprecated. (3.5 ended support on Oct 2nd, 2020.) Is it important to maintain these outdated Python version compatibility? Because from an open-source perspective, I think we should just modify the Travis CI to approve on checking 3.6+, but I guess that's up to you guys. |
…ld of valid pandas version
No, we don't need to maintain the tests for python 3.5 and earlier. We just haven't gotten rid of them for this repo yet. Sorry for the extra trouble there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All tests passing.
Use
np.ma.MaskedArraydirectly instead of importing from sklearn's version and import fromjoblibdirectly instead ofsklearn.externals. It's more proper to export directly instead of relying on sklearn externals and exposed packages which have no guarantees for maintenance and accessibility.As a rule of thumb, don't use publicly-exposed sklearn internal functions/tools when building a package for others because there will very likely be future dependency issues as things become deprecated and disappear.
Thank you guys so much for building this tool for the community. I've tried to use Dask's version, but their implementation doesn't seem to work with XGBoost that doesn't implement partial_fit() or something.
I'll continue to chip-in as I can if I encounter any further issues, thanks.