-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST CircleCI v2; No Docker tests #44
TST CircleCI v2; No Docker tests #44
Conversation
25d456c
to
ab0dba9
Compare
Update the test configuration file to CircleCI v2. Also take the opportunity to clean up testing -- instead of controlling the environment so stringently with a Dockerfile, just install the package and the requirements, and test that way (since that's in general how users will use this code).
ab0dba9
to
00932ca
Compare
f89be0e
to
7542ba5
Compare
eed29cd
to
db88142
Compare
c41f956
to
4c51566
Compare
4c51566
to
b49c02e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just out of curiosity: why no python 3.4?
Does this project officially support Python 3.4? If so, I'll add it to the tests. |
a7563df
to
321306f
Compare
@kcrum , our CircleCI tests now include Python v3.4, and I put a note in the README with our Python version requirements. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, LGTM!
Update the test configuration file to CircleCI v2. Also take the opportunity to clean up testing -- instead of controlling the environment so stringently with a Dockerfile, just install the package and the requirements, and test that way (since that's in general how users will use this code). Also test in multiple Python versions.
Closes #43 .