Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST CircleCI v2; No Docker tests #44

Merged

Conversation

stephen-hoover
Copy link
Contributor

@stephen-hoover stephen-hoover commented Sep 12, 2018

Update the test configuration file to CircleCI v2. Also take the opportunity to clean up testing -- instead of controlling the environment so stringently with a Dockerfile, just install the package and the requirements, and test that way (since that's in general how users will use this code). Also test in multiple Python versions.

Closes #43 .

@stephen-hoover stephen-hoover force-pushed the circleci-v2-config branch 4 times, most recently from 25d456c to ab0dba9 Compare September 12, 2018 15:43
Update the test configuration file to CircleCI v2. Also take the opportunity to clean up testing -- instead of controlling the environment so stringently with a Dockerfile, just install the package and the requirements, and test that way (since that's in general how users will use this code).
@stephen-hoover stephen-hoover force-pushed the circleci-v2-config branch 2 times, most recently from c41f956 to 4c51566 Compare September 12, 2018 16:25
Copy link
Contributor

@kcrum kcrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just out of curiosity: why no python 3.4?

@stephen-hoover
Copy link
Contributor Author

Does this project officially support Python 3.4? If so, I'll add it to the tests.

@stephen-hoover
Copy link
Contributor Author

@kcrum , our CircleCI tests now include Python v3.4, and I put a note in the README with our Python version requirements.

Copy link
Contributor

@kcrum kcrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, LGTM!

@stephen-hoover stephen-hoover merged commit 46c393d into civisanalytics:master Sep 20, 2018
@stephen-hoover stephen-hoover deleted the circleci-v2-config branch September 20, 2018 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants