Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for ruby 3.3.0 #31

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Adding support for ruby 3.3.0 #31

merged 1 commit into from
Jan 10, 2024

Conversation

uxxman
Copy link
Contributor

@uxxman uxxman commented Dec 26, 2023

No description provided.

@mobilutz
Copy link

mobilutz commented Jan 4, 2024

@jydli Would you be able to look at this?

Asking you, because you approved and merged the last ruby 3.2 upgrade here: #27

Thank you very much.

@jydli
Copy link
Contributor

jydli commented Jan 5, 2024

Hi, I'll start taking a look at this and finish a pass by early next week.

jydli
jydli approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@jydli jydli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I will merge and cut a release shortly.

@LRFalk01
Copy link

Looking forward to this being merged! Thanks 🎉

@jydli jydli merged commit e874c7d into civisanalytics:main Jan 10, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jydli jydli jydli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@uxxman @mobilutz @jydli @LRFalk01