Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a defined environment variable in place of apikey if it exists #232

Closed
kaihoffman opened this issue Jun 21, 2022 · 8 comments
Closed
Assignees

Comments

@kaihoffman
Copy link
Member

Instead of requiring civo apikey save for every environment, have it so that the system will use the API key defined in an environment variable if it exists. This means you would be able to configure the env var for a CI/CD system once, download Civo CLI and have it automatically look at the defined variable for the appropriate key to use.

Suggested names for the variable:

  • CIVO_APIKEY
  • CIVO_TOKEN

(proposed by @rawkode)

@alejandrojnm
Copy link
Member

This is done

@kaihoffman
Copy link
Member Author

Which of the variable names does it look for @alejandrojnm ? Just so we can update the README

@alejandrojnm
Copy link
Member

So sorry @kaihoffman I forget to mention we go with CIVO_TOKEN

@kaihoffman
Copy link
Member Author

Has this been built into a release @alejandrojnm @satakshigarg ? I don't see the documentation on the README and the latest release seems to have been made 23 days ago.

@alejandrojnm
Copy link
Member

alejandrojnm commented Sep 2, 2022

I think this is will be in the next release. We need update the doc.

@kaihoffman
Copy link
Member Author

I could update the docs but with the merge having happened it'd be weird being in the readme if that's not how the app works.

@alejandrojnm
Copy link
Member

You can add and create a PR and add to master, and when the release come out it will be there

@kaihoffman
Copy link
Member Author

That's what i mean though, will it be merged at the same time as you cut the release? Because if it's before, I might as well push it now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants