Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for bar based guessing #6

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

xstasi
Copy link

@xstasi xstasi commented Mar 19, 2023

This commit implements my suggestion in Issue #5.

The bar detection is manual but it works for my use case, if necessary the automatic detection can be added later on.

@xstasi
Copy link
Author

xstasi commented Apr 9, 2023

Hi there!

I have made a number of changes to the code in order to fit my use case, which is enhancing midi data with chord information for the purpose of ML data set building.

The default behaviour should be unchanged as my changes are all optional, so the code that used autochord before should be unaffected.

Feel free to incorporate my changes if you want, otherwise I'll keep using my fork :) completely up to you!

Cheers and thanks for starting the project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant