Skip to content

Commit

Permalink
readline: remove intermediate variable
Browse files Browse the repository at this point in the history
This commit removes an extrea intermediate variable. This
makes the call consistent with other uses of validateUint32()
in the codebase.

PR-URL: nodejs#31676
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
cjihrig committed Feb 9, 2020
1 parent 63f10b9 commit efec681
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions lib/readline.js
Expand Up @@ -123,8 +123,7 @@ function Interface(input, output, completer, terminal) {
terminal = input.terminal;
historySize = input.historySize;
if (input.tabSize !== undefined) {
const positive = true;
validateUint32(input.tabSize, 'tabSize', positive);
validateUint32(input.tabSize, 'tabSize', true);
this.tabSize = input.tabSize;
}
removeHistoryDuplicates = input.removeHistoryDuplicates;
Expand Down

0 comments on commit efec681

Please sign in to comment.