added support for 'include attributes list'. #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gerb-ster Could you document this feature, please? |
|
@gerb-ster I've made some adjustments to suit my own style. Hope that is okay |
|
Yeah sure, looking good! I'll add some documentation! |
cjmellor
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added support for an 'approvalInclude' array in which a user can specify which attributes should go through the 'approval procedure'. If this array is empty, we assume that all attributes need to go trough approval. This is done for backward compatibility.
Most of the changes have been made in the
MustBeApproved.phptrait, some logic is added there to make sure that included attributes go through approval and the ones not go through the normal process.I've also added a specific test for this functionality.