Add model and user to all event constructors #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…structors Add modal and user to event constructors
|
Will have a proper look when I finish my day job 😅 Thanks for contributing! |
|
Can you add some tests? I'd feel more at ease if I know it is returning exactly what is expected. |
# Conflicts: # src/Scopes/ApprovalStateScope.php
In this commit, an unnecessary space was removed in MustBeApproved.php file to make the code cleaner. In addition, the migration file's structure was slightly adjusted for better readability. Tests were also modified to increase test coverage and improve its quality, especially in the handling of 'fake_users'.
In this commit, we've updated the matched cases of ApprovalStatus in ApprovalStateScope.php. Rather than using a $model, we've changed to using $builder->getModel() in Dispatch Events to improve consistency and clarity of the code.
In this commit, Schema import has been added to the ApprovalStateScopeTest. This extra import is necessary for the functioning of our DB tests and ensures that the test for Approval Model states runs smoothly.
|
Thanks @nunodonato I ended up wanting this so just made sure the tests pass myself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small change to let all events receive the model and the authenticated user that triggered it.
On second thought, I think it might be more beneficial to change the constructor parameters to receive the
Approvalmodel itself, instead of the eloquent model that was changed. This is because from theApprovalwe can easily get to the subject, while the opposite might not be true (when a model has multipleApprovals).What do you think @cjmellor ?