fix: Rolling Back Model Fields with JSON Data #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update enhances support for JSON fields in the MustBeApproved trait. Changes include modifications to getDirtyAttributes and callCastAttribute methods to handle JSON casting. Extended tests are also added to validate the correct functionality with Models containing JSON fields.
This commit removes the user authentication check from the MustBeApproved trait. This change ensures that the trait is solely focused on approval processes and not concerned with user authentication, making for cleaner code and separation of concerns.
cjmellor
deleted the
54-issue-when-rolling-back-models-that-contain-json-fields
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix an issue where JSON data is sent to be approved.
Closes #54