Skip to content

Commit

Permalink
Revert "Skipping some hdbscan tests when cuda version is <= 11.2. (ra…
Browse files Browse the repository at this point in the history
…pidsai#4916)"

This reverts commit c80c13f.
  • Loading branch information
cjnolet committed Oct 10, 2022
1 parent 50716cf commit 66c6835
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 12 deletions.
8 changes: 2 additions & 6 deletions cpp/test/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -122,14 +122,10 @@ if(BUILD_CUML_TESTS)
ConfigureTest(PREFIX SG NAME GENETIC_PARAM_TEST PATH sg/genetic/param_test.cu OPTIONAL ML_INCLUDE)
endif()

if("${CMAKE_CUDA_COMPILER_VERSION}" VERSION_LESS_EQUAL "11.2")
# An HDBSCAN gtest is failing w/ CUDA 11.2 for some reason.
if(all_algo OR hdbscan_algo)
ConfigureTest(PREFIX SG NAME HDBSCAN_TEST PATH sg/hdbscan_test.cu OPTIONAL ML_INCLUDE)
endif()
if(all_algo OR hdbscan_algo)
ConfigureTest(PREFIX SG NAME HDBSCAN_TEST PATH sg/hdbscan_test.cu OPTIONAL ML_INCLUDE)
endif()


if(all_algo OR holtwinters_algo)
ConfigureTest(PREFIX SG NAME HOLTWINTERS_TEST PATH sg/holtwinters_test.cu OPTIONAL ML_INCLUDE)
endif()
Expand Down
4 changes: 0 additions & 4 deletions python/cuml/tests/test_hdbscan.py
Original file line number Diff line number Diff line change
Expand Up @@ -204,8 +204,6 @@ def test_hdbscan_blobs(nrows, ncols, nclusters,
np.sort(cuml_agg.cluster_persistence_), rtol=0.01, atol=0.01)


@pytest.mark.skipif(cp.cuda.driver.get_build_version() <= 11020,
reason="Test failing on driver 11.2")
@pytest.mark.parametrize('dataset', test_datasets.values())
@pytest.mark.parametrize('cluster_selection_epsilon', [0.0, 50.0, 150.0])
@pytest.mark.parametrize('min_samples_cluster_size_bounds', [(150, 150, 0),
Expand Down Expand Up @@ -625,8 +623,6 @@ def test_all_points_membership_vectors_moons(nrows,
sk_membership_vectors)


@pytest.mark.skipif(cp.cuda.driver.get_build_version() <= 11020,
reason="Test failing on driver 11.2")
@pytest.mark.parametrize('nrows', [1000])
@pytest.mark.parametrize('n_points_to_predict', [200, 500])
@pytest.mark.parametrize('ncols', [10, 25])
Expand Down
2 changes: 0 additions & 2 deletions python/cuml/tests/test_pca.py
Original file line number Diff line number Diff line change
Expand Up @@ -232,8 +232,6 @@ def test_pca_inverse_transform(datatype, input_type,
5e-5, with_sign=True)


@pytest.mark.skipif(cp.cuda.driver.get_build_version() <= 11020,
reason="Test failing on driver 11.2")
@pytest.mark.parametrize('nrows', [4000, 8000])
@pytest.mark.parametrize('ncols', [5000, stress_param(20000)])
@pytest.mark.parametrize('whiten', [True, False])
Expand Down

0 comments on commit 66c6835

Please sign in to comment.