Add nox-poetry #570
Merged
Add nox-poetry #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
This was referenced Oct 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds nox-poetry, a spinoff of this project, as a global dependency. This package replaces the boilerplate that was previously injected into the
noxfile.pyof generated projects to integrate Nox and Poetry.Having this on PyPI means this glue code no longer needs to be copied into every project, and users can receive bugfixes in a normal way, without the hassle of updating their project from the template. Also, moving this into a separate package made it possible to provide a much better integration of Poetry and Nox than a bunch of functions in
noxfile.pywere able to. With nox-poetry, users can write Nox sessions just as they would with a setuptools-based project; only a single import at the top of the file is required.There are also some drawbacks, which should be named here: This package needs to be installed into the global developer environment, alongside Nox. So we're no longer only depending on Poetry and Nox. Furthermore, nox-poetry currently relies on monkey-patching to intercept calls to
session.install. (Maybe a plugin architecture for Nox could help here?)Closes #567