Support packages whose name does not match the project name #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if package name and project name are not similar ('-' replaced by '_'),
a 'package' key will be added in pyproject.toml file.
|
I didn't see any part in documentation that should be update according to this modification of |
|
Failure of tests-3.9 with windows seems not related to my modifications. |
cjolowicz
requested changes
Nov 3, 2020
Co-authored-by: Claudio Jolowicz <cjolowicz@gmail.com>
|
White space handling corrected. With this version we have a line break between |
cjolowicz
reviewed
Nov 6, 2020
Co-authored-by: Claudio Jolowicz <cjolowicz@gmail.com>
cjolowicz
changed the title
|
Woot 🎉 |
|
Do you think we should add a test case in CI ? |
|
Yes, but I would not add this to the CI workflow. This should be in a test suite run by pytest, see #616. Unfortunately, we don't have this infrastructure yet. But it's overdue, so if you want to start work on that, that's more than welcome. It's a bunch of work, though. |
Merged
paw-lu
pushed a commit
to paw-lu/cookiecutter-hypermodern-python
that referenced
this pull request
Mar 8, 2021
…z#631) * Add test to specify package name when necessary if package name and project name are not similar ('-' replaced by '_'), a 'package' key will be added in pyproject.toml file. * Avoid blank line * whitespace handling correction * Remove useless line break
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if the package name and project name are not similar (more than
-replaced by_), apackagekey will be added inpyproject.tomlfile.Example:
fix: #546