Require click 8.x #947
Merged
Require click 8.x #947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 15, 2021 18:26
|
The version constraint already allows click 8. Or is this about disallowing click 7? |
Yes, since you are creating a project with cookiecutter, what is the meaning of allowing click 7? I don't get it. Also, we stay in the same pattern as other dependencies so it is simpler to understand/maintain. |
|
It's relevant if you update an existing project, for example with cruft. |
cjolowicz
added
dependencies
|
Oh well, I guess project updates need to review and merge dependencies anyway. |
cjolowicz
approved these changes
Jun 15, 2021
|
BTW have you tried cruft @cjolowicz? I was looking for a good solution to update project based on updated cookiecutter, didn't find an easy one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #908