Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include dependency groups in constraints file #1139

Merged
merged 26 commits into from
Jul 8, 2023
Merged

Include dependency groups in constraints file #1139

merged 26 commits into from
Jul 8, 2023

Conversation

cjolowicz
Copy link
Owner

Include dependency groups other than dev in the constraints file used when installing packages. Previously, dependencies in those groups weren't kept at the versions from the lock file. This also fixes the warning The --dev option is deprecated, use the --with dev notation instead.

Fixes #977
Fixes #873

@cjolowicz
test: add Project.locked_packages to conftest
f0b8a5b
@cjolowicz
test: add functional test for dependency groups in constraints
44ff14a
@cjolowicz
test: add unit test for Config.dependency_groups
3dde6bd
@cjolowicz
feat: add Config.dependency_groups
5b7b212
@cjolowicz
refactor: extract fixture create_config
8246eac
@cjolowicz
test: add unit test for no groups
a91a7cc
@cjolowicz
test: add unit test for dev group
f4ba5e5
@cjolowicz
feat: support the legacy dev dependency group
1d4eac2
@cjolowicz
feat: include all dependency groups in constraints
2e1658f
@cjolowicz
test: support python <3.11 in test project
58885e5
@cjolowicz
test: add unit test for Poetry.version
dcb08f4
@cjolowicz
feat: add Poetry.version
a516e79
@cjolowicz
test: add test for invalid Poetry version
825a103
@cjolowicz
feat: raise exception if poetry version cannot be parsed
544f754
@cjolowicz
perf: cache Poetry.version
d34da9c
@cjolowicz
test: add test for cached version
a6b613b
@cjolowicz
test: add unit test for Poetry.has_dependency_groups
c27927c
@cjolowicz
feat: add Poetry.has_dependency_groups
bfb9115
@cjolowicz
feat: support Poetry <1.2
4f5556a
@cjolowicz
test: adapt FakeSession.run_always for poetry --version
866677f
@cjolowicz
test: adapt coverage exclusion to changed code path
713d9d7
@cjolowicz
refactor: extract variable dependency_groups
fe108e2
@cjolowicz
test: skip functional test on Poetry < 1.2
b497c81
@cjolowicz
build: add importlib-metadata to dev dependencies
76e1bcc
@cjolowicz
fix: avoid walrus for Python 3.7
609e384
@cjolowicz
chore: avoid type error on conditional import
077fcb8
@cjolowicz cjolowicz added the bug Something isn't working label Jul 8, 2023
@cjolowicz cjolowicz merged commit 66ddf00 into main Jul 8, 2023
37 checks passed
@cjolowicz cjolowicz deleted the feat/dependency-groups branch July 8, 2023 22:53
@johnthagen johnthagen mentioned this pull request Jul 8, 2023
Open
This was referenced Jul 8, 2023
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nox-poetry does not respect the new dependency groups from Poetry Warnings with Poetry 1.2.0
1 participant
@cjolowicz