Fix crash when users run Nox with the new --no-install option
#382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjolowicz
force-pushed
the
no-install
branch
2 times, most recently
from
59bd91a
to
9f689b9
Compare
cjolowicz
changed the title
nox --no-install--no-install option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
--no-installoption introduced in Nox 2021.6.6 means thatsession.run_alwayscan return None instead of the command output. This breaks assumptions nox-poetry makes when using itsPoetryhelper class to build a package or export a requirements file. Currently, this will lead to an assertion failure, and a cryptic error message.This PR fixes the behavior when
--no-installis passed:session.installorsession.poetry.installroot, we skip all commands silently.session.poetry.export_requirementsorsession.poetry.build_package, we cannot skip the command silently, because the function must return something. Instead, we raise an exception with a helpful message.