Image previews and better link recognition

[corywalker]

[cjstewart88]

Should this be max-width? If an image is 100px wide, it would stretch it to 200px, messing the quality up.

[corywalker]

Good call. Now uses max-width

[DAddYE]

is inline image an option?

[cjstewart88]

For now I'd prefer not to do the inline images due to nsfw issues that could come up for users. I think linking off to the image will suffice. If you can remove that bit of the code I'd be happy to merge this.

[bblack]

How do we feel about a popup image on hover ?
On Feb 3, 2013 3:17 PM, "DAddYE" notifications@github.com wrote:

is inline image an option?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/31#issuecomment-13053350.

[cjstewart88]

I'd feel better about that.

Sent from my iPhone

On Feb 3, 2013, at 5:41 PM, Brian Black notifications@github.com wrote:

How do we feel about a popup image on hover ?
On Feb 3, 2013 3:17 PM, "DAddYE" notifications@github.com wrote:

is inline image an option?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/31#issuecomment-13053350.

—
Reply to this email directly or view it on GitHub.

[JaniL]

How about if it's done in a similar way like in Reddit Enhancement Suite? An icon would be added to picture links, that would show the picture inline when clicked.

http://redditenhancementsuite.com/wiki/index.php?title=Inline_Image_Viewer

[cjstewart88]

I'd be fine with that.

Sent from my iPhone

On Feb 15, 2013, at 6:35 AM, Jani Luukko notifications@github.com wrote:

How about if it's done in a similar way like in Reddit Enhancement Suite? An icon would be added to picture links, that would show the picture inline when clicked.

http://redditenhancementsuite.com/wiki/index.php?title=Inline_Image_Viewer

—
Reply to this email directly or view it on GitHub.

[cjstewart88]

Closing this.