make collections work with unhashable objects

cjw296 · Jan 31, 2019 · 13b7656 · 13b7656
1 parent 7fbfa10
commit 13b7656
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/chide/collection.py b/chide/collection.py
@@ -14,7 +14,11 @@ def __init__(self, mapping):
     def _attrs(self, type_, attrs, nest):
         computed_attrs = dict(self.mapping[type_])
         for key, value in computed_attrs.items():
-            if value in self.mapping and key not in attrs:
+            try:
+                value_in_mapping = value in self.mapping
+            except TypeError:
+                value_in_mapping = False
+            if value_in_mapping and key not in attrs:
                 computed_attrs[key] = nest(value)
         computed_attrs.update(attrs)
         return computed_attrs

diff --git a/tests/test_collection.py b/tests/test_collection.py
@@ -84,3 +84,9 @@ def identify_type_c(type_, attrs):
         compare(sample1.key, expected=1)
         self.assertTrue(sample1 is sample2)
 
+    def test_unhashable_attributes(self):
+        unhashable = []
+        collection = Collection({dict: {'y': unhashable}})
+        made = collection.make(dict)
+        compare(made, expected={'y': []})
+        assert made['y'] is unhashable