Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created helper module for handling console input #62

Merged
merged 1 commit into from
Oct 3, 2019

Conversation

stevefai
Copy link
Collaborator

@stevefai stevefai commented Oct 3, 2019

Created a new module in utils/console-reader.js for handling user console input.

The module exports a promisified version of readline.question, which can be reused across the app to make code more readable and easier to test.

Currently, console-reader is only used inside yo-dawg.js.

Steps to Test

node yo-dawg.js

Screenshots

Deploy Notes

Checklist

  • I have tested these code changes and included the relevant urls and screenshots.
  • [x ] I have updated our build tasks accordingly (if applicable).
  • [ x] I have updated our documentation accordingly (if applicable).
  • I have linted the code that I've included in this PR (if applicable).
  • My code follows the code style of this project.
  • My code is ready for review.

@stevefai stevefai changed the title Created helper module for handling console input and promisified readline Created helper module for handling console input Oct 3, 2019
@cjwilburn cjwilburn self-requested a review October 3, 2019 18:56
Copy link
Owner

@cjwilburn cjwilburn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants