Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate the demo's from the main library #49

Closed
spyhunter99 opened this issue Mar 24, 2017 · 8 comments
Closed

Separate the demo's from the main library #49

spyhunter99 opened this issue Mar 24, 2017 · 8 comments

Comments

@spyhunter99
Copy link
Contributor

A suggestion, separate the demo classes into a separate module instead of embedding them in the main library. I can open a PR for this

@stevesobol
Copy link
Member

Hey Spyhunter!

Rogan turned over the cjwizard library to me a while ago. I have had ZERO time to devote to it, unfortunately, but I need to change that, since I essentially own the project at this point. So, I want to dig in and start helping you with further development of the library.

There are things we should discuss that don't need to be attached to GitHub issues. I want to go ahead and set up a slack channel for that stuff. Also, of the issues we have open now, let me know what you want me to start work on, because I want to start contributing to the project next week.

I also registered cjwizard.com and at some point I'd like to put a website there, but that's a REALLY low priority at the moment.

Please let me know how I can help!

@spyhunter99
Copy link
Contributor Author

Sweet, you can always use maven to create the site. It's quite easy and i can do a pr for it too if you like. Let me work through a few issues on my end and get back to you

@stevesobol
Copy link
Member

Maven's great for doing a quick informational site. I won't be using Maven, though, as I want to do a fancier site (common branding with some other dev tools I'm working on, etc) - plus, I'm a web developer and want to add this new site to my portfolio. :) I'm steve at LobosStudios.com - drop me an email when you are ready. Looking forward to working with everyone. :)

@stevesobol
Copy link
Member

This is essentially the same issue as #39 - I'm going to close this issue and work on that one

@spyhunter99
Copy link
Contributor Author

it isn't but i think some of the previous prs have squashed this. i'll redo it

@stevesobol
Copy link
Member

Well, I'll reopen this one then, but I'm confused as to what the differences are.

@stevesobol stevesobol reopened this Jun 4, 2017
@spyhunter99
Copy link
Contributor Author

spyhunter99 commented Jun 4, 2017 via email

@stevesobol
Copy link
Member

OK. That means I can go ahead and close this issue and just work on that one, then?

stevesobol added a commit that referenced this issue Aug 3, 2017
#39 code shuffling to separate the demo from the main the library
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants