Align flask version with CKAN, to avoid incompatibilities #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 5, 2017 20:35
…ope when ckan upgrades its flask. Suggested versions are in requirements.txt but I dont suggest people use it because you should use the ckan versions of things. The setup.py is really enough as its really not choosy about versions.
…ope when ckan upgrades its flask. Suggested versions are in requirements.txt but I dont suggest people use it because you should use the ckan versions of things. The setup.py is really enough as its really not choosy about versions.
|
This is long overdue... I've hit this again. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: ckan/datapusher#124
setup.py is no longer picky about versions - CKAN now specifies Flask and requests versions so that should not be overwritten when you install datapusher (during with you install ckan-service-provider, which might be done in the ckan deb package automatically).