support quoted sort args for backwards compat

ckan · Sep 2, 2015 · 09600a8 · 09600a8
1 parent 9d7295b
commit 09600a8
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/ckanext/datastore/helpers.py b/ckanext/datastore/helpers.py
@@ -99,4 +99,11 @@ def literal_string(s):
     """
     Return s as a postgres literal string
     """
-    return u"'" + s.replace(u"'", u"''") + u"'"
+    return u"'" + s.replace(u"'", u"''").replace(u'\0', '') + u"'"
+
+
+def identifier(s):
+    """
+    Return s as a quoted postgres identifier
+    """
+    return u'"' + s.replace(u'"', u'""').replace(u'\0', '') + u'"'
diff --git a/ckanext/datastore/plugin.py b/ckanext/datastore/plugin.py
@@ -357,6 +357,8 @@ def _parse_sort_clause(self, clause, fields_types):
             return False
 
         field = clause_match.group(1)
+        if field[0] == field[-1] == u'"':
+            field = field[1:-1]
         sort = (clause_match.group(3) or u'asc').lower()
 
         if field not in fields_types:
@@ -460,7 +462,8 @@ def _sort(self, data_dict, fields_types):
 
         for clause in clauses:
             field, sort = self._parse_sort_clause(clause, fields_types)
-            clause_parsed.append(u'"{0}" {1}'.format(field, sort))
+            clause_parsed.append(
+                u'{0} {1}'.format(datastore_helpers.identifier(field), sort))
 
         return clause_parsed