Add config-tool tests

ckan/cli/config_tool.py

@@ -68,10 +68,12 @@ def config_tool(config_filepath, options, section, edit, merge_filepath):
             config_filepath, merge_filepath
         )
     if not (options or merge_filepath):
-        return error_shout(u'No options provided')
+        error_shout(u'No options provided')
+        raise click.Abort()
     try:
         ct.config_edit_using_option_strings(
             config_filepath, options, section, edit=edit
         )
     except ct.ConfigToolError as e:
         error_shout(e)
+        raise click.Abort()

ckan/tests/cli/test_config_tool.py

@@ -0,0 +1,79 @@
+# -*- coding: utf-8 -*-
+
+import os
+import pytest
+from ckan.cli.cli import ckan
+from six.moves.configparser import ConfigParser, NoOptionError
+
+
+@pytest.fixture
+def config_file(tmp_path):
+    dest = tmp_path / u'config.ini'
+    tpl = os.path.join(os.path.dirname(__file__), u'data/config_tool.ini')
+    with open(tpl, u'rb') as data:
+        dest.write_bytes(data.read())
+    return dest
+
+
+def _parse(config_file):
+    parser = ConfigParser()
+    parser.read([str(config_file)])
+    return parser
+
+
+def test_config_no_params(cli, config_file):
+    """test-config requires some params for update.
+    """
+    result = cli.invoke(ckan, [u'config-tool', str(config_file)])
+    assert result.exit_code
+
+
+def test_config_unset_debug(cli, config_file):
+    """Existing values can be updated.
+    """
+    assert _parse(config_file).get(u'app:main', u'debug') == u'true'
+    result = cli.invoke(
+        ckan,
+        [u'config-tool', str(config_file), u'debug=false'])
+    assert not result.exit_code
+    assert _parse(config_file).get(u'app:main', u'debug') == u'false'
+
+
+def test_config_create_custom_debug(cli, config_file):
+    """New values can be added
+    """
+    with pytest.raises(NoOptionError):
+        _parse(config_file).get(u'app:main', u'custom_debug')
+    result = cli.invoke(
+        ckan, [u'config-tool',
+               str(config_file), u'custom_debug=false'])
+    assert not result.exit_code
+    assert _parse(config_file).get(u'app:main', u'custom_debug') == u'false'
+
+
+def test_config_custom_section(cli, config_file):
+    """Custom section updated when specified.
+    """
+    assert _parse(config_file).get(u'server:main', u'port') == u'5000'
+    result = cli.invoke(ckan, [
+        u'config-tool',
+        str(config_file), u'-s', u'server:main', u'port=8000'
+    ])
+    assert not result.exit_code
+    assert _parse(config_file).get(u'server:main', u'port') == u'8000'
+
+
+def test_merge_into_new_file(cli, config_file, tmp_path):
+    """New file can be created without updating old one.
+    """
+    dest = tmp_path / u'new_config.ini'
+    dest.touch()
+    assert _parse(config_file).get(u'app:main', u'debug') == u'true'
+    result = cli.invoke(
+        ckan,
+        [u'config-tool',
+         str(dest), u'-f',
+         str(config_file), u'debug=false'])
+    assert not result.exit_code
+    assert _parse(config_file).get(u'app:main', u'debug') == u'true'
+    assert _parse(dest).get(u'app:main', u'debug') == u'false'