Merge branch '2048-upgrade-repoze' of https://github.com/brew/ckan in…

…to brew-2048-upgrade-repoze

ckan/config/who.ini

@@ -49,7 +49,8 @@ plugins =
     auth_tkt
 
 [authenticators]
-plugins = 
+plugins =
+    auth_tkt
     ckan.lib.authenticator:OpenIDAuthenticator
     ckan.lib.authenticator:UsernamePasswordAuthenticator
 

ckan/new_tests/lib/test_base.py

@@ -1,6 +1,89 @@
 from nose import tools as nose_tools
 
-from ckan.new_tests import helpers
+import ckan.new_tests.factories as factories
+import ckan.new_tests.helpers as helpers
+
+
+class TestLoginView(helpers.FunctionalTestBase):
+
+    def _maybe_follow(self, response, **kw):
+        """
+        Follow all redirects. If this response is not a redirect, do nothing.
+        Returns another response object.
+
+        (backported from WebTest 2.0.1)
+        """
+        remaining_redirects = 100  # infinite loops protection
+
+        while 300 <= response.status_int < 400 and remaining_redirects:
+            response = response.follow(**kw)
+            remaining_redirects -= 1
+
+        assert remaining_redirects > 0, "redirects chain looks infinite"
+        return response
+
+    def test_registered_user_login(self):
+        '''
+        Registered user can submit valid login details at /user/login and
+        be returned to appropriate place.
+        '''
+        app = helpers._get_test_app()
+
+        # make a user
+        user = factories.User()
+
+        # get the form
+        response = app.get('/user/login')
+        # ...it's the second one
+        login_form = response.forms[1]
+
+        # fill it in
+        login_form['login'] = user['name']
+        login_form['password'] = 'pass'
+
+        # submit it
+        submit_response = login_form.submit()
+        # let's go to the last redirect in the chain
+        final_response = self._maybe_follow(submit_response)
+
+        # the response is the user dashboard, right?
+        final_response.mustcontain('<a href="/dashboard">Dashboard</a>',
+                                   '<span class="username">{0}</span>'
+                                   .format(user['fullname']))
+        # and we're definitely not back on the login page.
+        final_response.mustcontain(no='<h1 class="page-heading">Login</h1>')
+
+    def test_registered_user_login_bad_password(self):
+        '''
+        Registered user is redirected to appropriate place if they submit
+        invalid login details at /user/login.
+        '''
+        app = helpers._get_test_app()
+
+        # make a user
+        user = factories.User()
+
+        # get the form
+        response = app.get('/user/login')
+        # ...it's the second one
+        login_form = response.forms[1]
+
+        # fill it in
+        login_form['login'] = user['name']
+        login_form['password'] = 'badpass'
+
+        # submit it
+        submit_response = login_form.submit()
+        # let's go to the last redirect in the chain
+        final_response = self._maybe_follow(submit_response)
+
+        # the response is the login page again
+        final_response.mustcontain('<h1 class="page-heading">Login</h1>',
+                                   'Login failed. Bad username or password.')
+        # and we're definitely not on the dashboard.
+        final_response.mustcontain(no='<a href="/dashboard">Dashboard</a>'),
+        final_response.mustcontain(no='<span class="username">{0}</span>'
+                                   .format(user['fullname']))
 
 
 class TestCORS(helpers.FunctionalTestBase):

requirements.in

@@ -17,7 +17,7 @@ python-dateutil>=1.5.0,<2.0.0
 pyutilib.component.core==4.5.3
 repoze.who-friendlyform==1.0.8
 repoze.who.plugins.openid==0.5.3
-repoze.who==1.0.19
+repoze.who==2.0
 requests==2.3.0
 Routes==1.13
 solrpy==0.9.5

requirements.txt

@@ -31,7 +31,7 @@ python-dateutil==1.5
 python-openid==2.2.5
 pyutilib.component.core==4.5.3
 repoze.lru==0.6
-repoze.who==1.0.19
+repoze.who==2.0
 repoze.who-friendlyform==1.0.8
 repoze.who.plugins.openid==0.5.3
 requests==2.3.0