Merge pull request #7852 from ckan/faster-js-i18n

i18n js: serve faster with LazyJSONObject

changes/7852.misc

@@ -0,0 +1,2 @@
+serve i18n js faster with LazyJSONObject
+generate compact json instead of pretty-printed json to send less data

ckan/lib/i18n.py

@@ -310,7 +310,9 @@ def _build_js_translation(
                 for _, msgstr in ordered_plural:
                     plural.append(msgstr)
     with open(dest_filename, u'w', encoding='utf-8') as f:
-        s = json.dumps(result, sort_keys=True, indent=2, ensure_ascii=False)
+        s = json.dumps(
+            result, sort_keys=True, ensure_ascii=False, separators=(',', ':')
+        )
         f.write(s)
 
 

ckan/views/api.py

@@ -19,6 +19,7 @@
 from ckan.lib.helpers import url_for
 from ckan.lib.base import render
 from ckan.lib.i18n import get_locales_from_config, get_js_translations_dir
+from ckan.lib.lazyjson import LazyJSONObject
 
 from ckan.lib.navl.dictization_functions import DataError
 from ckan.logic import get_action, ValidationError, NotFound, NotAuthorized
@@ -478,8 +479,8 @@ def i18n_js_translations(
     source = os.path.join(js_translations_folder, f"{lang}.js")
     if not os.path.exists(source):
         return "{}"
-    translations = json.load(io.open(source, "r", encoding="utf-8"))
-    return _finish_ok(translations)
+    translations = io.open(source, "r", encoding="utf-8").read()
+    return _finish_ok(LazyJSONObject(translations))
 
 
 # Routing