Recline preview uses insecure MapQuest, causes 'Mixed Content' warning in Internet Explorer

[ThrawnCA]

This can be fixed in recline.js by:

• Replacing http://developer.mapquest.com/content/osm/mq_logo.png with a relative protocol URL,
  //developer.mapquest.com/content/osm/mq_logo.png
• Replacing http://otile{s}.mqcdn.com/tiles/1.0.0/osm/{z}/{x}/{y}.png with a relative protocol URL on the secure site,
  //otile{s}-s.mqcdn.com/tiles/1.0.0/osm/{z}/{x}/{y}.png

[domoritz]

Related: datopian/datahub#345. This fixes the dataproxy url but not mapquest.

Map fix: datopian/datahub#369

[ThrawnCA]

Thanks, domoritz.

That pull request fixes the map URL, but not the logo image. Won't it still trigger the Mixed Content warning?

Also, you left out the '-s' in the new hostname, which is necessary for SSL to work.

[domoritz]

@ThrawnCA Thank you.

[domoritz]

@johnglover Do you think we should fix this manually in CKANs version of recline or use the latest recline to fix this?

[johnglover]

@domoritz We should use the latest Recline.

[domoritz]

@johnglover Cool. Then someone should merge datopian/datahub#369 ;-) Do you have time?

[johnglover]

@domoritz Yes I'll have a look

[amercader]

FYI this was fixed on the relevant maps on ckanext-spatial as part of ckan/ckanext-spatial@028d26e

[johnglover]

This is now fixed in Recline master but we still have to update CKAN's recline to the latest version.

[amercader]

@johnglover will we be updating recline before 2.2?

[johnglover]

@amercader No I don't think so, it probably makes more sense to wait until the new view stuff has been merged in. I have moved this to 2.3 for now.

[vitorbaptista]

FYI I've upgraded recline on #1251. When that's merged, this should be fixed as well.

[nigelbabu]

Latest recline is now merged. Closing.