Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Term translations of organizations #1274

Closed
metaodi opened this issue Oct 9, 2013 · 1 comment
Closed

Term translations of organizations #1274

metaodi opened this issue Oct 9, 2013 · 1 comment
Labels
z Backport 2.1.3
Milestone
CKAN 2.2

Comments

@metaodi
Copy link
Member

metaodi commented Oct 9, 2013

I just noticed that organizations are not being translated. When I checked the multilingual extension, it seems that the organizations have been completely forgotten. Now I'm not sure how I should fix this.

Easy solution: let the MultilingualGroup implement IOrganizationController. As organizations are just specialiced groups this makes sense. And as long as we don't have to treat groups and organizations different. On my machine this worked very well.

Another possibility would be to create a new MultilingualOrganization class that extends MultilingualGroup and create a seperate multilingual_organization extension.
metaodi pushed a commit to ogdch/ckan that referenced this issue Oct 9, 2013
[ckan#1274] Added IOrganizationController to MultilingualGroup
db57578 
This ensures that organizations are being translated just like groups
@ghost ghost assigned johnglover Oct 10, 2013
johnglover added a commit that referenced this issue Oct 24, 2013
@johnglover
[#1274] PEP8
904dbf0
johnglover added a commit that referenced this issue Oct 24, 2013
@johnglover
[#1274] Add tests for organization translation
3be621a
@johnglover johnglover mentioned this issue Oct 24, 2013
Merged
@johnglover
Copy link
Contributor

Fixed with #1291

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
z Backport 2.1.3
Projects
None yet
Milestone
CKAN 2.2
Development

No branches or pull requests
3 participants
@amercader @johnglover @metaodi