Group/about calls setup_template_variables with an empty context

[davidread]

setup_template_variables is normally called supplying a context with model, session and user. However the Group About page seems an exception, where the context is {}.

https://github.com/okfn/ckan/blob/05c5c2cb260aa6b518bbd5ee2612f45780780cb1/ckan/controllers/group.py#L846

Is there any reason to deprive this of the model etc.? Is this a place where only logic methods should be called? Or can I add in the proper context here?

Specifically, this affects my hierarchy extension:
https://github.com/datagovuk/ckanext-hierarchy/blob/57ada7ba765881f2ffd696d25da30de69684c1bd/ckanext/hierarchy/plugin.py#L41

[davidread]

if @wardi could comment, I'll take it on

[wardi]

@davidread I added the call to _setup_template_variables because it was missing before 05c27ce and I needed it in my about page, but I didn't need any context values. I'm sure you're right, the context should be set up in the normal way instead.

[davidread]

Cheers Ian, I'll add this in then.

[davidread]

PR now merged into master (and may go into CKAN 2.2)