fix paster db clean again #1656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User.get() leaves an open transaction when the site user is added to the pylons context, commit here closes it so it does not lock tables when running paster db clean
defer commit from get_site_user and attach it to pylons context first
|
Cheers for this one @joetsoi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_site_user would close the session and dispose of it, then the call to model.User.get() would reopen a new connection and transaction that acquires an exclusive lock on the tables that does not get closed before the the drop tables is run.
This pr fixes it by deferring the commit and remove of get_site_user until after the pylons.c.user_obj is assigned.
I have tested this with the datapusher and harvester and they appear to still work correctly with this patch