[#1278] Fix placeholder select2 #1680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitoravelino
changed the title
vitorbaptista
added a commit
that referenced
this pull request
May 2, 2014
[#1278] Fix placeholder select2
|
Good job! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I looked through select2 code and I found where was and when the bug was introduced. Coincidentally, it was in version 3.4.2 that it is the current one ckan is using. See https://github.com/ivaynberg/select2/issues/1614.
What I did was upgrade to 3.4.5. You might me wondering why I didn't upgrade to the latest version (3.4.6). Well, I tried but I got a weird error and I thought that it would be better to stick with 3.4.5.
The latest version included a lot of fixes and the interval between the latest and 3.4.5 was more than 5 months (https://github.com/ivaynberg/select2/releases). That made me think that the latest version might be not as stable as the 3.4.5 because the project wasn't being actively maintained as before.