Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in theming tutorial #1751

Closed
jared-brown opened this issue Jun 9, 2014 · 4 comments
Closed

Error in theming tutorial #1751

jared-brown opened this issue Jun 9, 2014 · 4 comments
Assignees

Comments

@jared-brown
Copy link
Contributor

Item 2 in "Initializing a JavaScript module" asks you to create the file ckanext-example_theme/templates/snippets/package_item.html, and in that file, to replace the {% block package_item_content %} block with custom content. The block in the source package_item.html snippet is actually just {% block content %}.

@nigelbabu
Copy link
Contributor

@jared-brown Would you be up for submitting a pull request for both the issues you've filed?

@amercader
Copy link
Member

@jared-brown, you can edit files directly from Github itself, and it will automatically create a pull request for you:

screenshot from 2014-06-10 11 02 51

@amercader amercader self-assigned this Jun 10, 2014
@jared-brown
Copy link
Contributor Author

OK, I did as instructed and generated the pull requests.

On Tue, Jun 10, 2014 at 3:11 AM, Adrià Mercader notifications@github.com
wrote:

@jared-brown https://github.com/jared-brown, you can edit files
directly from Github itself, and it will automatically create a pull
request for you:

[image: screenshot from 2014-06-10 11 02 51]
https://cloud.githubusercontent.com/assets/200230/3228441/a883c476-f086-11e3-8062-2f529c620826.png


Reply to this email directly or view it on GitHub
#1751 (comment).

@amercader
Copy link
Member

Fixed in #1756

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants