Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/Remove TestActionAuth #2128

Closed
rossjones opened this issue Dec 9, 2014 · 1 comment
Closed

Fix/Remove TestActionAuth #2128

rossjones opened this issue Dec 9, 2014 · 1 comment

Comments

@rossjones
Copy link
Contributor

TestActionAuth (in test_coding_standards.py) checks whether each action has a corresponding auth function, not all do. In additing auth functions for these just returning success: True is probably the right thing to do so that they can easily be overridden. Otherwise these may cause problems when trying to override auth functions unless the auth_audit_exempt decorator is used.

Sometimes it is because actions like organization_activity_list check auth against organization_show, perhaps we should have the organization_activity_list auth function and have it decide to delegate to organization_show?

@davidread
Copy link
Contributor

This issue was closed due to inactivity. Feel free to reopen if you have more feedback or are interested it working on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants