Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ActionError.extra_msg is not needed #2167

Closed
davidread opened this issue Dec 29, 2014 · 2 comments
Closed

ActionError.extra_msg is not needed #2167

davidread opened this issue Dec 29, 2014 · 2 comments

Comments

@davidread
Copy link
Contributor

Simplify ActionError by removing its .extra_msg.

ActionError inherits from Exception but instead of using Exception.message, it introduces its own ActionError.extra_msg and has logic to save and return it in place of Exception.message. I can't see the point, apart from maybe the word 'extra' implying it is optional. So I suggest we just get rid of the extra_msg and store what was there in Exception.message instead.
davidread pushed a commit that referenced this issue Dec 29, 2014
[#2167] Remove ActionError.extra_msg.
94129ae
@davidread
Copy link
Contributor Author

BTW extra_msg was introduced in this commit:

39a37c3b

@davidread davidread mentioned this issue Dec 29, 2014
Merged
rossjones added a commit that referenced this issue Dec 31, 2014
@rossjones
Merge pull request #2168 from ckan/2167-remove-extra_msg
6024ac3 
[#2167] Remove ActionError.extra_msg.
@rossjones
Copy link
Contributor

This was merged into 2165-check-access-log (#2166) as requested.

davidread pushed a commit that referenced this issue Dec 31, 2014
[#2167] Fix DeprecationWarning: BaseException.message
d8b5956
@davidread davidread mentioned this issue Dec 31, 2014
Merged
rossjones added a commit that referenced this issue Dec 31, 2014
@rossjones
Merge pull request #2178 from ckan/2167-remove-extra_msg
8520ca9 
[#2167] Fix DeprecationWarning: BaseException.message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rossjones @davidread