Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark IGenshiStreamFilter as legacy #271

Closed
seanh opened this issue Jan 11, 2013 · 5 comments

Comments

Projects
None yet
3 participants
@seanh
Copy link
Contributor

commented Jan 11, 2013

and make sure this shows up in the plugin interfaces docs

also any other plugin interfaces that should be marked legacy or deprecated

@tobes

This comment has been minimized.

Copy link
Contributor

commented Jan 18, 2013

it would be easy enough to poll all IGenshiStreamFilter extensions at startup and do a log.critical or similar.

Do we also want to do a log.warn when genshi templates are used (maybe not till 2.1 though)

@ghost ghost assigned vitorbaptista Jan 22, 2013

@vitorbaptista

This comment has been minimized.

Copy link
Contributor

commented Jan 22, 2013

I started doing this in https://github.com/vitorbaptista/ckan/commit/d0115492b36e5894395398d40273fbcd589b9049. I've added a warning every time a IGenshiStreamFilter is used, adding the extension's name.

I don't like the deprecated message in the docs so far. I think it's missing what should be used instead of IGenshiStreamFilter... what do you think?

@seanh

This comment has been minimized.

Copy link
Contributor Author

commented Jan 22, 2013

I think the jinja equivalent of igenshistreamfilter is overriding blocks in templates, or if the template doesn't have any blocks you have to override the whole template file. @tobes @johnmartin

@tobes

This comment has been minimized.

Copy link
Contributor

commented Jan 23, 2013

@vitorbaptista

I'd still prefer that we did this a plugin registration time to say this plugin uses the IGenshiStreamFilter which is deprecated as

a) we will not hit the place you added the warning for jinja2 templates so there will be no warning
b) That way we only warn once and it will be at application startup.

@seanh

yeah the jinja2 way is {% ckan_extends %} or via ITemplateHelpers

@vitorbaptista

This comment has been minimized.

Copy link
Contributor

commented Feb 7, 2013

Solved by #365

@seanh seanh closed this Feb 14, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.