Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

markdown_extract causes exception in certain cases #2746

Closed
thriuin opened this issue Nov 20, 2015 · 1 comment
Closed

markdown_extract causes exception in certain cases #2746

thriuin opened this issue Nov 20, 2015 · 1 comment

Comments

@thriuin
Copy link
Contributor

thriuin commented Nov 20, 2015

I recently encountered a case where the markdown_extract function was failing because of the empty value that was being passed in the notes field (we customizing heavily with scheming). The problem could be traced to this line:

if (text is None) or (text.strip() == ''):

This can be avoided by simplifying this test to:

if not text:

PR to follow.

wardi added a commit that referenced this issue Nov 24, 2015
[#2746] Simplify test for empty or missing value in markdown_extract
@wardi
Copy link
Contributor

wardi commented Nov 24, 2015

fixed via 305de4d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants