Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

group_controller() on IGroupForm not in interface #2771

Closed
metaodi opened this issue Dec 4, 2015 · 2 comments
Closed

group_controller() on IGroupForm not in interface #2771

metaodi opened this issue Dec 4, 2015 · 2 comments
Assignees

Comments

@metaodi
Copy link
Member

@metaodi metaodi commented Dec 4, 2015

In plugins.py, there is a call to a function group_controller on IGroupForm plugins.

This method is not mentioned on the IGroupForm interface. This leads to a strange bug: I'm using ckanext-scheming and this implements IGroupForm for a custom organization schema. But because this method is not present, it will use the group controller instead of the organization controller to generate links (e.g. for the pagination).

I guess this method just went missing and should be added to the interface and can then be implemented by extensions as needed.

@davidread
Copy link
Contributor

@davidread davidread commented Dec 8, 2015

Sounds good, are you ok to implement this?

@metaodi
Copy link
Member Author

@metaodi metaodi commented Dec 8, 2015

Sure, just wanted to ask first if I understood the concept correctly. PR follows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants