Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect 'download resource' hyperlink when a resource is unable to upload to datastore #2873

Closed
Mbrownshoes opened this issue Feb 10, 2016 · 6 comments
Closed

Incorrect 'download resource' hyperlink when a resource is unable to upload to datastore #2873

Mbrownshoes opened this issue Feb 10, 2016 · 6 comments
Assignees
@smotornyuk
Labels
zBackport 2.3.4 zBackport 2.4.3 zBackport 2.5.2

Comments

@Mbrownshoes
Copy link

When a dataset cannot be previewed in the Data Explorer - e.g. when the dataset it too large, or has not been loaded to the DataStore (e.g. http://demo.ckan.org/dataset/bad-hyperlink-example/resource/36a112c0-7a4e-40da-aa0d-8e0c67e64957) the Data Explorer is providing an incorrectly addressed "Download resource" hyperlinked button
image

The hyperlink URL http://demo.ckan.org/dataset/bad-hyperlink-example/resource/36a112c0-7a4e-40da-aa0d-8e0c67e64957 is missing the terminating text /download/
@amercader
Copy link
Member

@smotornyuk @Engerrs can either of you have a look at this one? It should be easy to track where the URL is coming from. The template used is this one:

https://github.com/ckan/ckan/blob/master/ckan/templates/package/snippets/resource_view.html

Thanks!

@smotornyuk
Copy link
Member

I will take that one

@amercader amercader assigned smotornyuk and unassigned amercader Mar 17, 2016
@amercader
Copy link
Member

Thanks @smotornyuk!

@wardi
Copy link
Contributor

wardi commented Mar 17, 2016

Was this not fixed by #2599

smotornyuk added a commit to smotornyuk/ckan that referenced this issue Mar 24, 2016
@smotornyuk
[ckan#2873] Use resource.url as raw_resource_url
a406000 
`resource_view` template uses raw_resouce_url in order to create
download link if resource can't be displayed, but this variable is not
passed into snippet. To make that simpler, use resource.url property
for download button.
@smotornyuk
Copy link
Member

No, problem here in variable that not passed into template

@amercader
Copy link
Member

Fixed by #2930

amercader pushed a commit that referenced this issue Mar 29, 2016
@smotornyuk @amercader
[#2873] Use resource.url as raw_resource_url
6bba236 
`resource_view` template uses raw_resouce_url in order to create
download link if resource can't be displayed, but this variable is not
passed into snippet. To make that simpler, use resource.url property
for download button.

Conflicts:
	ckan/templates/package/snippets/resource_view.html
amercader pushed a commit that referenced this issue Mar 29, 2016
@smotornyuk @amercader
[#2873] Use resource.url as raw_resource_url
428c44e 
`resource_view` template uses raw_resouce_url in order to create
download link if resource can't be displayed, but this variable is not
passed into snippet. To make that simpler, use resource.url property
for download button.
amercader pushed a commit that referenced this issue Mar 29, 2016
@smotornyuk @amercader
[#2873] Use resource.url as raw_resource_url
d5dc61b 
`resource_view` template uses raw_resouce_url in order to create
download link if resource can't be displayed, but this variable is not
passed into snippet. To make that simpler, use resource.url property
for download button.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smotornyuk smotornyuk

Labels
zBackport 2.3.4 zBackport 2.4.3 zBackport 2.5.2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@wardi @amercader @Mbrownshoes @smotornyuk