Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ambiguity in UI labels for the last_modified and revision_timestamp fields #3028

Closed
augusto-herrmann opened this issue May 17, 2016 · 5 comments
Assignees

Comments

@augusto-herrmann
Copy link

The meaning and presentation of the fields should be more clear and consistent.

last_modified: the date and time when the actual data has been last changed
revision_timestamp: the date and time when the resource metadata has been last changed

If this is the correct meaning for the fields, the visual label on the templates for the resource should be consistent with that:

last_modified -> "Data last updated"
revision_timestamp -> "Metadata last updated"

Currently these fields are used interchangeably to display the same label "Last updated". See

<td>{{ h.render_datetime(res.last_modified) or h.render_datetime(res.revision_timestamp) or h.render_datetime(res.created) or _('unknown') }}</td>
https://github.com/ckan/ckan/blob/master/ckan/templates/package/resource_read.html#L158

This problem was mentioned in passing on #1874 but was not fixed there as it was not the main topic of discussion.

@amercader amercader self-assigned this May 19, 2016
@amercader
Copy link
Member

@augusto-herrmann You are right, what you are proposing makes more sense. Do you want to submit a pull request? It seems like a very small change

@gleb-rudenko
Copy link

I can work on it

gleb-rudenko pushed a commit to gleb-rudenko/ckan that referenced this issue Feb 22, 2017
@augusto-herrmann
Copy link
Author

Thanks for the PR, @gleb-rudenko !

@gleb-rudenko
Copy link

@augusto-herrmann, np 👍

@gleb-rudenko
Copy link

@amercader, any progress with this one?

wardi added a commit that referenced this issue Mar 28, 2017
…ified-and-revision_timestamp-fields

#3028 / UI labels for the last_modified and revision_timestamp fields
@wardi wardi closed this as completed Mar 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants