Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ckan.logic.schema file is messy #3057

Closed
3 tasks done
k-nut opened this issue May 25, 2016 · 0 comments · Fixed by #3058
Closed
3 tasks done

ckan.logic.schema file is messy #3057

k-nut opened this issue May 25, 2016 · 0 comments · Fixed by #3058
Assignees
@wardi

Comments

@k-nut
Copy link
Contributor

k-nut commented May 25, 2016 •
edited

There are a couple of pep8/style issues in ckan/logic/schema.py
They are mainly

  • unsued imports
  • not 2 lines between functions
  • dictionaries with duplicate keys

I will clean those in three separate commits and then tick them off here.

The last checkbox probably needs some explanation: here we call update on a dictionary and pass it a new dictionary. The new one contains the keys cache_last_updated and last_modified twice so that the second empty declarations overwrite the first one. I assume that the values that actually contain something are the ones that are wanted and will remove the empty ones in favor of them.
k-nut added a commit to k-nut/ckan that referenced this issue May 25, 2016
@k-nut
[ckan#3057] reorder imports and remove unused ones
045582e
k-nut added a commit to k-nut/ckan that referenced this issue May 25, 2016
@k-nut
[ckan#3057] remove duplicate keys
cece50b
k-nut added a commit to k-nut/ckan that referenced this issue May 25, 2016
@k-nut
[ckan#3057] always use short form when refering to imported functions
4c81720
@k-nut k-nut mentioned this issue May 25, 2016
Merged
5 tasks
k-nut added a commit to k-nut/ckan that referenced this issue May 26, 2016
@k-nut
[ckan#3057] remove validators that were overwritten
f560e18
k-nut added a commit to k-nut/ckan that referenced this issue May 26, 2016
@k-nut
[ckan#3057] include schema.py in coding standard test & pep8 it
a09f4d3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wardi wardi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cleanup schema.py k-nut/ckan
2 participants
@wardi @k-nut