Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate notify_after_commit #3633

Closed
davidread opened this issue Jun 23, 2017 · 0 comments
Closed

Deprecate notify_after_commit #3633

davidread opened this issue Jun 23, 2017 · 0 comments
Assignees
@davidread

Comments

@davidread
Copy link
Contributor

Because it doesn't work.

notify_after_commit (from interface IDomainObjectModification) never gets called because session._object_cache is blank for this sort of SessionExtension event, so CKAN don't know what object has been committed.

I see there are no tests for it, and no-one (on Github) has used it.
@davidread davidread self-assigned this Jun 23, 2017
@davidread davidread changed the title Remove notify_after_commit Deprecate notify_after_commit Jun 23, 2017
davidread pushed a commit that referenced this issue Jun 23, 2017
[#3633] Marked notify_after_commit interface deprecated and removed n…
a35d083 
…on-working code that calls it.
@davidread davidread mentioned this issue Jun 23, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidread davidread

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@davidread