Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permission labels are indexed by type text in SOLR #3863

Closed
Zharktas opened this issue Oct 10, 2017 · 3 comments · Fixed by #3864 or #3867
Closed

Permission labels are indexed by type text in SOLR #3863

Zharktas opened this issue Oct 10, 2017 · 3 comments · Fixed by #3864 or #3867
Assignees

Comments

@Zharktas
Copy link
Member

CKAN Version if known (or site URL)

2.7, master

Please describe the expected behaviour

Organization Admin should see organizations private datasets even when SOLR indexing has been changed to accommodate different languages. The permission label should not be index by language rules.

Please describe the actual behaviour

If indexing rules are changed for example to use EdgeNGram, the permission label id's are indexed by these rules and organization admin, editor or member can not see organizations private datasets.

What steps can be taken to reproduce the issue?

Apply EdgeNGram to solr indexing.

Create organization.
Create user.
Add user to organization.
Create private Dataset to organization.

Possible fix

Use type textgen instead of text in the default schema.xml.

@wardi wardi self-assigned this Oct 10, 2017
@wardi
Copy link
Contributor

wardi commented Oct 10, 2017

@Zharktas sounds right to me. Mind submitting a PR?

@TkTech
Copy link
Member

TkTech commented Oct 10, 2017

Use string not textgen, which in CKAN's schema is not the same as the old Solr 1.* textgen FieldType (confusing I know).

@Zharktas
Copy link
Member Author

@wardi submitted minor PR for this.

wardi added a commit that referenced this issue Oct 10, 2017
…type-to-string-in-solr

[#3863] Change permission_labels type to string in schema.xml
wardi added a commit that referenced this issue Oct 11, 2017
benjaminleighton added a commit to CSIRO-enviro-informatics/ckan that referenced this issue Nov 29, 2018
… damc

* commit 'a763445db630f8b60e9c7f59aff0d113c56713b2': (44 commits)
  Fix solr container build after 2.7.3 merge.
  Fix migration script for ckan#4042
  Fix coding standards tests
  Update version number for 2.7.3
  Add link to script in changelog
  Add script for fixing issue ckan#4042
  Update notes on changelog
  Update CHANGELOG 2.7.3
  Fix CI by changing build docker context for solr
  Run as Solr user, as this version won't start as root by default
  Upgrade scripts version
  Fix wrong version
  Upgrade Solr Docker image
  Merge pull request ckan#4100 from Engerrs/4094-org-and-grp-custom-fields-deletion
  Improve text view rendering
  Disallow solr parameters
  Add notices about ckan#4043 and ckan#3864
  [ckan#3863] Update schema version number
  [ckan#3863] Change permission_labels type to string in schema.xml
  Compile translations
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants