You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
ckan.lib.base.render() is a mess of old code that is probably no longer used. Now that we are starting to port Pylons controllers to Flask in earnest is the perfect time to do a long overdue cleanup.
For simplicity, all existing caching logic from render will be moved to separate function called only for pylons' routes, thus it can be safely dropped after finishing flask migrations.
completely remove PageCacheMiddleware. First reason for this - it wasn't used for rendering snippets and extended templates, so profit of using it is quite small. In addition, it seems that most of CKAN users configure different variations of caching using separate tools(ex. serving over nginx)
ckan.lib.base.render()
is a mess of old code that is probably no longer used. Now that we are starting to port Pylons controllers to Flask in earnest is the perfect time to do a long overdue cleanup.The Canadian open data portal has been running for a while in a extremely simplified version of it. @wardi and @TkTech provided context in this IRC conversation.
Essentially:
PageCacheMiddleware
is being used at all, and if not nuke it.I'm happy to keep all current stuff in a
_render_template_pylons()
function and have the cleaned up version just apply to FlaskThe text was updated successfully, but these errors were encountered: