Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace paste.deploy converters #4797

Closed
amercader opened this issue May 23, 2019 · 1 comment · Fixed by #4966
Closed

Replace paste.deploy converters #4797

amercader opened this issue May 23, 2019 · 1 comment · Fixed by #4966
Labels
Beginner Friendly Good for Contribution
Projects
Python 3 Support

Comments

@amercader
Copy link
Member

This should be straightforward. We use paste.deploy's asbool, asint, aslist (specially asbool) in different parts of the code and they are exposed on the toolkit. Basically we need to implement our own versions of them and replace the references

Approach

  • Write our implementation of the three functions based on the current ones. These need to be imported early in the execution, so they should be probably placed in ckan/common.py or ckan/lib/base.py.
  • Replace all imports in the code base from paste.deploy.converters to the new location.
  • Replace the references in the toolkit module.

Story points

3
@amercader amercader added this to To do in Python 3 Support May 23, 2019
@amercader amercader moved this from To do to To do - Transition in Python 3 Support May 23, 2019
@amercader amercader mentioned this issue Jun 19, 2019
Closed
f-osorio pushed a commit to f-osorio/ckan that referenced this issue Sep 3, 2019
[ckan#4797] Replace converters from pasete.deploy
74b7c42 
Create local versions of the `asbool`, `asint`, and `aslist` converts
from paste.deploy. They are in `ckan.common.py`
f-osorio pushed a commit to f-osorio/ckan that referenced this issue Sep 3, 2019
[ckan#4797] Update import references
80c8ef4 
Update import references for 25 files to refer to new converters:
`ckan.common` -- previous import were from `paste.deploy`

All tests passing.
@f-osorio f-osorio mentioned this issue Sep 3, 2019
Merged
5 tasks
@amercader amercader moved this from To do - Transition to In Progress in Python 3 Support Sep 3, 2019
@amercader
Copy link
Member Author

PR by @f-osorio here: #4966

@amercader amercader moved this from In Progress to Done in Python 3 Support Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Beginner Friendly Good for Contribution
Projects
No open projects
Python 3 Support
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

4797 replace paste converters f-osorio/ckan
1 participant
@amercader