Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Debug" flag warning in INI file has inadequate wording #4871

Closed
ThrawnCA opened this issue Jun 26, 2019 · 3 comments
Closed

"Debug" flag warning in INI file has inadequate wording #4871

ThrawnCA opened this issue Jun 26, 2019 · 3 comments
Assignees

Comments

@ThrawnCA
Copy link
Contributor

The INI file template has a warning on the debug flag, but that warning doesn't properly match the documentation. Specifically, the warning says that the flag must be false in a production environment, but the real rule, as described at https://docs.ckan.org/en/latest/maintaining/configuration.html, is that it must be false for a public site. These are very different criteria; it's not uncommon to have publicly facing, but not advertised, non-production environments.

CKAN Version if known (or site URL)

CKAN 2.8.2

Please describe the expected behaviour

The warning on debug should state that it must be false for publicly visible sites.

Please describe the actual behaviour

The warning on debug states that it must be false for production sites.

@amercader
Copy link
Member

This sounds reasonable @ThrawnCA, do you want to submit a quick PR with the change?

@ThrawnCA
Copy link
Contributor Author

ThrawnCA commented Jun 28, 2019

What branch(es) should I base it on? Just master?

@ThrawnCA
Copy link
Contributor Author

Opened #4880

amercader pushed a commit that referenced this issue Jul 2, 2019
- it's not just production environments that are at risk, any publicly visible site must not use debug mode
- github #4871
amercader added a commit that referenced this issue Jul 2, 2019
…warning

update the 'debug' warning to better match the documentation, github #4871
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants