Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_external parameter kept on Pylons generated URLs #4872

Closed
amercader opened this issue Jun 26, 2019 · 0 comments · Fixed by #4873
Closed

_external parameter kept on Pylons generated URLs #4872

amercader opened this issue Jun 26, 2019 · 0 comments · Fixed by #4873
Assignees
@amercader

Comments

@amercader
Copy link
Member

The url_for wrapper for Pylons requests correctly handles Flask's _external parameter to generate fully qualified URLs, but fails to remove it, resulting in an extraneous param added to the URL, eg: http://example.com/dataset/test?_external=True
@amercader amercader self-assigned this Jun 26, 2019
amercader added a commit that referenced this issue Jun 26, 2019
@amercader
[#4872] Remove _external query param on Pylons generated URLs
e5848c2 
Fixes #4872

The url_for wrapper for Pylons requests correctly handles Flask's
`_external` parameter to generate fully qualified URLs, but fails
to remove it, resulting in an extraneous param added to the URL,
 eg: http://example.com/dataset/test?_external=True
@amercader amercader mentioned this issue Jun 26, 2019
Merged
amercader added a commit that referenced this issue Jun 27, 2019
@amercader
[#4872] [#4872] Pep8
6e4a0b9
smotornyuk added a commit that referenced this issue Jun 27, 2019
@smotornyuk
Merge pull request #4873 from ckan/4872-remove-extra-external-parameter
7256b29 
[#4872] Remove _external query param on Pylons generated URLs
amercader added a commit that referenced this issue Jul 1, 2019
@amercader
[#4872] Remove _external query param on Pylons generated URLs
4568708 
Fixes #4872

The url_for wrapper for Pylons requests correctly handles Flask's
`_external` parameter to generate fully qualified URLs, but fails
to remove it, resulting in an extraneous param added to the URL,
 eg: http://example.com/dataset/test?_external=True
amercader added a commit that referenced this issue Jul 1, 2019
@amercader
[#4872] [#4872] Pep8
b73a6ba
fostermh pushed a commit to cioos-siooc/ckan that referenced this issue Sep 10, 2021
@amercader @fostermh
[ckan#4872] Remove _external query param on Pylons generated URLs
8cbf721 
Fixes ckan#4872

The url_for wrapper for Pylons requests correctly handles Flask's
`_external` parameter to generate fully qualified URLs, but fails
to remove it, resulting in an extraneous param added to the URL,
 eg: http://example.com/dataset/test?_external=True
fostermh pushed a commit to cioos-siooc/ckan that referenced this issue Sep 10, 2021
@amercader @fostermh
[ckan#4872] [ckan#4872] Pep8
d9a9c29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amercader amercader

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#4872] Remove _external query param on Pylons generated URLs ckan/ckan
1 participant
@amercader